Skip to content

boards: Add the Nordic nRF5340 audio DK #49720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 13, 2023
Merged

boards: Add the Nordic nRF5340 audio DK #49720

merged 2 commits into from
Jan 13, 2023

Conversation

@koffes
Copy link
Contributor

@koffes koffes commented Aug 31, 2022 •
edited by Thalley
Loading

Migration of boardfiles from sdk-nrf to Zephyr.

fixes #47296

@Thalley Thalley self-requested a review August 31, 2022 07:54
nordicjm
nordicjm requested changes Aug 31, 2022
View reviewed changes
@koffes koffes force-pushed the nrf5340-audio-boardfiles branch 3 times, most recently from 243f6af to cbc3486 Compare August 31, 2022 10:04
@koffes koffes marked this pull request as ready for review August 31, 2022 10:18
@koffes koffes requested a review from carlescufi as a code owner August 31, 2022 10:18
@zephyrbot zephyrbot added the platform: nRF Nordic nRFx label Aug 31, 2022
@zephyrbot zephyrbot requested a review from anangl August 31, 2022 10:19
@koffes koffes requested a review from nordicjm August 31, 2022 10:27
Thalley
Thalley reviewed Aug 31, 2022
View reviewed changes
Copy link
Contributor

@Thalley Thalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koffes Is the CI building anything for this board? In other words, are we in this PR testing that these board files are valid and an application can be built for the netcore and the appcore?

@koffes koffes force-pushed the nrf5340-audio-boardfiles branch from 125c8b1 to cbc3486 Compare August 31, 2022 10:42
nordicjm
nordicjm requested changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@nordicjm nordicjm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Squash into 1 commit
  2. This board does not build:
-- Found BOARD.dts: /tmp/aa/zephyr/boards/arm/nrf5340_audio_dk_nrf5340/nrf5340_audio_dk_nrf5340_cpuapp.dts
devicetree error: 'label' is marked as deprecated in 'properties:' in /tmp/aa/zephyr/dts/bindings/sdhc/zephyr,sdhc-spi-slot.yaml for node /soc/peripheral@50000000/spi@a000/sdhc@0.
-- In: /tmp/aa/zephyr/twister-out/nrf5340_audio_dk_nrf5340_cpuapp/samples/drivers/audio/dmic/sample.drivers.audio.dmic/zephyr
  1. Looks to be targeting an old version of zephyr, compare against the nrf5340dk board and update as needed:
warning: RPMSG_SERVICE_IPM_TX_NAME (defined at boards/arm/nrf5340_audio_dk_nrf5340/Kconfig.defconfig:96) defined without a type

warning: RPMSG_SERVICE_IPM_RX_NAME (defined at boards/arm/nrf5340_audio_dk_nrf5340/Kconfig.defconfig:100) defined without a type

@koffes koffes force-pushed the nrf5340-audio-boardfiles branch from cbc3486 to b2c1000 Compare September 9, 2022 12:56
Thalley
Thalley requested changes Sep 9, 2022
View reviewed changes
nordicjm
nordicjm requested changes Sep 9, 2022
View reviewed changes
@koffes koffes added the DNM This PR should not be merged (Do Not Merge) label Sep 9, 2022
@koffes
Copy link
Contributor Author

koffes commented Sep 12, 2022

Thanks @nordicjm. I see that there are further changes which has been introduced to the boardfiles. I am going through the files one by one, comparing to nRF5340 DK. Will update this PR soon.

@koffes koffes force-pushed the nrf5340-audio-boardfiles branch 2 times, most recently from 09b8a6b to ea62a7a Compare September 12, 2022 14:06
@koffes koffes requested review from alexsven and nordicjm September 12, 2022 14:16
@koffes koffes force-pushed the nrf5340-audio-boardfiles branch from ea62a7a to f5087fa Compare September 13, 2022 10:18
@carlescufi carlescufi requested review from gmarull, greg-fer, larsgk and nordicjm and removed request for gmarull, greg-fer, larsgk and nordicjm January 13, 2023 14:20
@carlescufi carlescufi merged commit 3bd9352 into zephyrproject-rtos:main Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larsgk larsgk larsgk left review comments

@Thalley Thalley Thalley approved these changes

@carlescufi carlescufi carlescufi approved these changes

@anangl anangl anangl approved these changes

@gmarull gmarull gmarull approved these changes

@nordicjm nordicjm nordicjm approved these changes

@tejlmand tejlmand tejlmand left review comments

@alexsven alexsven Awaiting requested review from alexsven

@jhedberg jhedberg Awaiting requested review from jhedberg

@Vudentz Vudentz Awaiting requested review from Vudentz

@alwa-nordic alwa-nordic Awaiting requested review from alwa-nordic

@sjanc sjanc Awaiting requested review from sjanc

@asbjornsabo asbjornsabo Awaiting requested review from asbjornsabo

@hermabe hermabe Awaiting requested review from hermabe

@microbuilder microbuilder Awaiting requested review from microbuilder

@theotherjimmy theotherjimmy Awaiting requested review from theotherjimmy

@jori-nordic jori-nordic Awaiting requested review from jori-nordic

@nashif nashif Awaiting requested review from nashif

@joerchan joerchan Awaiting requested review from joerchan

@cvinayak cvinayak Awaiting requested review from cvinayak

+2 more reviewers

@pirun pirun pirun left review comments

@greg-fer greg-fer greg-fer requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@anangl anangl

Labels

area: Bluetooth area: Boards area: Regulators area: TF-M ARM Trusted Firmware-M (TF-M) manifest-trusted-firmware-m platform: nRF Nordic nRFx

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LE Audio: Move board files for nRF5340 Audio development kit upstream